Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Party is missing from many tests #48

Closed
davipo opened this issue Jan 24, 2019 · 2 comments
Closed

Party is missing from many tests #48

davipo opened this issue Jan 24, 2019 · 2 comments

Comments

@davipo
Copy link
Contributor

davipo commented Jan 24, 2019

Our parser captures party data from many input files, but many of our tests don't check this field. We test it mainly for primary elections, but also for several general elections. Because party data is in our results files, it should be tested.

(The party field is needed to distinguish "Scattering" records in primary elections.)

To add party data to the tests, it should be looked up manually in the input files, to guarantee an independent test. Currently about 74 tests need party data. (109 tests specify party, about 97 are for nonpartisan offices.)

Please edit the wi-elections.feature.csv file to add party data. (The older format wi-elections.feature file may be removed, since it is not used by the new faster testing program.)

@nbdavies
Copy link
Contributor

This will be addressed in davipo#21

@davipo
Copy link
Contributor Author

davipo commented Feb 18, 2019

Thanks Nick, for looking up and adding party to many tests.
I've revised run_spot_tests.py to always test party, even when empty. (Removed kludge to skip party test when party is empty in test data.) All tests now pass.

@davipo davipo closed this as completed Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants