Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Add c bindings #2

Open
adam-hanna opened this issue Aug 13, 2018 · 5 comments
Open

Add c bindings #2

adam-hanna opened this issue Aug 13, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@adam-hanna
Copy link
Member

No description provided.

@adam-hanna adam-hanna added the enhancement New feature or request label Aug 13, 2018
@adam-hanna adam-hanna self-assigned this Aug 13, 2018
@miguelmota
Copy link
Contributor

adding c binding seems hacky. I think it's worth implementing the util functions in every language bc it's simple hex encoding/decoding

@adam-hanna
Copy link
Member Author

adam-hanna commented Aug 30, 2018

@miguelmota
Yeah, that's a good thought. My main reasoning was two-fold:

  1. We would eventually add c bindings for almost every piece of code, making it easier to support other languages, at least initially
  2. Any changes would only need to be made in one repo, reducing bugs

@miguelmota
Copy link
Contributor

  1. the util functions are trivial enough that it may take less time to implement than figuring out c binding integration for the language

  2. this is true, though there's the possibility that edge cases could exist which would be harder to debug

  3. it makes the application bundle bigger and native implementation will have a faster start time

@adam-hanna
Copy link
Member Author

All good points. I'll add another con to your list:

  1. it requires go to be installed and $ make deps for any sdk that uses it.

@miguelmota
Copy link
Contributor

good to know

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants