Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Github Request template creates issues in other repos when selected #268

Open
dbwiddis opened this issue Jan 13, 2025 · 7 comments
Open
Labels
bug Something isn't working

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Jan 13, 2025

What is the bug?

Other repositories in the opensearch-project org are inheriting all of the templates in the .github/ISSUE_TEMPLATES directory (unless they have their own such directory). For most templates (bug report, feature request, etc.) this is desired behavior. However, the new GITHUB_REQUEST_TEMPLATE introduced in #238 seems like it should only be visible in this repo and not org-wide.

How can one reproduce the bug?

  1. Go to another repo in the organization that does not have its own ISSUE_TEMPLATES directory, and select the Issues tab.
  2. Click on the "New Issue" button.
  3. Observe the "Create a GitHub Issue" button (which creates an issue in the other repo, that can't action it). See for example, https://github.com/opensearch-project/opensearch-remote-metadata-sdk/issues/new/choose
  4. Click the "Get Started" button to create an issue
  5. Observe that the issue got created in that repo and not here. See, for example: [GitHub Request] This request is in the wrong repo opensearch-remote-metadata-sdk#46

What is the expected behavior?

Either the template is not visible in other repos, or if it must be, the issue is created in the .github repo.

Do you have any screenshots?

Screenshot 2025-01-13 at 12 51 09 PM

Do you have any additional context?

From the GitHub documentation it appears you can add a projects: line to the issue template YAML to identify the repo where the issue should be created.

projects: ["octo-org/1", "octo-org/44"]
@dbwiddis dbwiddis added bug Something isn't working untriaged labels Jan 13, 2025
@gaiksaya
Copy link
Member

gaiksaya commented Jan 13, 2025

Hi @dbwiddis

Looking at few other repos here, I do not see this issue template being reflected.
https://github.com/opensearch-project/opensearch-build/issues/new/choose
https://github.com/opensearch-project/opensearch-ci/issues/new/choose
Also noticed that when I click on edit templates in above repos they redirect to <repo>/tree/main/.github/ISSUE_TEMPLATE which is not the case for opensearch-remote-metadata-sdk repo (it redirects to this repo).
@peterzhuamazon @rishabh6788 Any idea if this is specific to new repos being created or some setting that needs to be fixed?
P.S: Looks like admin team is also missing in metadata-sdk repo. Unable to see settings repo.

@peterzhuamazon
Copy link
Member

I think sdk repo did not have its own templates thus the issue:
https://github.com/opensearch-project/opensearch-remote-metadata-sdk/tree/main/.github

@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jan 13, 2025

Admin team is now part of sdk repo.

@peterzhuamazon
Copy link
Member

Seems like projects: ["octo-org/1", "octo-org/44"] is only for project which we dont really need here. Because we want to limit it to a specific repo not a project.

@peterzhuamazon
Copy link
Member

Our project board is already sorting on all the repos at the moment, not just .github.

@peterzhuamazon
Copy link
Member

I made issues show their repositories on the board, and an oncall can manually correct it upon creation.
https://github.com/orgs/opensearch-project/projects/208/views/33

@dbwiddis
Copy link
Member Author

Hi @dbwiddis

Looking at few other repos here, I do not see this issue template being reflected.

Yes, if a template has its own .github/ISSUE_TEMPLATES directory it overrides the default one, but then we lose all the goodness of standard templates and DRY. :)

A lot of the older repos have templates from before they were standardized. See:

Seems like projects: ["octo-org/1", "octo-org/44"] is only for project which we dont really need here. Because we want to limit it to a specific repo not a project.

Ah, yes, that makes sense.

Looking around looks like changing the url in the config.yml link could apply, but this just has the links that go below the "Create Issue" buttons. So I don't really know how to have a "local" template in the .github repo....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants