Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[On-boarding]: Onboarding skills to build repo #4378

Closed
zane-neo opened this issue Jan 29, 2024 · 5 comments
Closed

[On-boarding]: Onboarding skills to build repo #4378

zane-neo opened this issue Jan 29, 2024 · 5 comments

Comments

@zane-neo
Copy link
Contributor

What is the name of your plugin?

opensearch-skills

What is the link to your GitHub repo?

https://github.com/opensearch-project/skills

Targeted release version

2.12

What type of the plugin are we on-boarding?

OpenSearch

Did you read the on-boarding document

Yes

Does this plugin has all the necessary automated tests?

Yes

Have you completed the required reviews including Security reviews, UX reviews?

No UX review and security review is ongoing

Have you on-boarded automated security scanning for the GitHub repo associated with this plugin?

No

Additional context

No response

@zane-neo zane-neo added on-boarding untriaged Issues that have not yet been triaged labels Jan 29, 2024
@peterzhuamazon peterzhuamazon added release v2.12.0 and removed untriaged Issues that have not yet been triaged labels Jan 29, 2024
@peterzhuamazon
Copy link
Member

peterzhuamazon commented Jan 29, 2024

Seems like this is something they want to onboard for 2.12.0.

@prudhvigodithi could you take a look at this? Seems like their repo is already public.

cc: @bbarani

Thanks.

@prudhvigodithi
Copy link
Member

Thanks @peterzhuamazon, hey @zane-neo can you please take a look at the recent onboarding issue with dashboards-assistant plugin.
#4322

Were you able to build the distribution using this new plugin? Steps are mentioned in the on-boarding document.
Pending tasks before closing this issue:

  • On-board to 2.12.0 manifest
  • On-board to test workflow by adding integration tests

Thanks!

@peterzhuamazon
Copy link
Member

Just followed up with Zan on a few things:

  1. Zan will open a PR for changes in opensearch-build including github/workflows, manifests, more.
  2. Zan will resolve the maven publish issues in skills build.gradle, as well as repo order fix.
  3. Peter will help onboard skills repo with SONATYPE credential access, so skills can use github actions to publish maven artifacts to staging sonatype repo.

There are some other small things to follow up later.
Thanks.

@peterzhuamazon
Copy link
Member

Onboarding complete.
cc @prudhvigodithi to monitor the distribution build for skills in 2.12.0.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants