Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Split PPL tool into two tools for generate and execute #138

Closed
joshuali925 opened this issue Jan 18, 2024 · 2 comments
Closed
Labels
enhancement New feature or request untriaged

Comments

@joshuali925
Copy link
Member

Is your feature request related to a problem?
The current PPL tool implementation will execute PPL as well

PPLQueryRequest pplQueryRequest = new PPLQueryRequest(ppl, jsonContent, null, "jdbc");

This can be useful for chat, where it would need the query response to reply to the user. But for query assist in event analytics observability plugin, the PPL tool is only used to generate the query, execution will be covered by event analytics. This allows UI to make any additional modifications to the query. It's ok to just ignore PPL execution results from PPL tool, but it's extra overhead and a bit unreliable since sometimes we need to extract the original PPL from error messages

String pplError = "execute ppl:" + ppl + ", get error: " + e.getMessage();

What solution would you like?
Split PPL tool into two parts, one for generate, one for execute

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
cc @xinyual

@xinyual
Copy link
Collaborator

xinyual commented Jan 25, 2024

Add one more field to solve this issue. Pass "execute": false when you register Tool

@joshuali925
Copy link
Member Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
Development

No branches or pull requests

2 participants