-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Cinder customServiceConfig globally in DCN DT #459
Set Cinder customServiceConfig globally in DCN DT #459
Conversation
923d166
to
572aacf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this if we've tested it somewhere
The customServiceConfig for cinder in the DCN DT is used to set the storage_availability_zone. We wish to do this for all Cinder services in the default site (`az0`), not just for cinderAPI or cinderBackup as the AZ was missing from the cinder-scheduler. Thus, we will move it to the global section under the cinder template and out of the cinderAPI and cinderBackup since they will inherit it. We still need to set the backend_availability_zone in all cinderVolumes except az0 since it will also inherit the new default value. However, the additional line is kept in az0's customServiceConfig to make the pattern easier to see for az0, az1, az2, etc. Jira: https://issues.redhat.com/browse/OSPRH-11915 Signed-off-by: John Fulton <[email protected]>
This has passed a CI test and is ready to merge. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fultonj, krcmarik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
5576566
into
openstack-k8s-operators:main
/cherry-pick 18.0-fr1 |
@fultonj: new pull request created: #463 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…59-to-18.0-fr1 [18.0-fr1] Set Cinder customServiceConfig globally in DCN DT This is an automated cherry-pick of #459 /assign fultonj Reviewed-by: Andrew Bays <[email protected]>
The customServiceConfig for cinder in the DCN DT is used to set the storage_availability_zone. We wish to do this for all Cinder services in the default site (
az0
), not just for cinderAPI or cinderBackup as the AZ was missing from the cinder-scheduler. Thus, we will move it to the global section under the cinder template and out of the cinderAPI and cinderBackup since they will inherit it. We still need to set the backend_availability_zone in all cinderVolumes except az0 since it will also inherit the new default value. However, the additional line is kept in az0's customServiceConfig to make the pattern easier to see for az0, az1, az2, etc.Jira: https://issues.redhat.com/browse/OSPRH-11915