Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Cinder customServiceConfig globally in DCN DT #459

Merged

Conversation

fultonj
Copy link
Contributor

@fultonj fultonj commented Dec 3, 2024

The customServiceConfig for cinder in the DCN DT is used to set the storage_availability_zone. We wish to do this for all Cinder services in the default site (az0), not just for cinderAPI or cinderBackup as the AZ was missing from the cinder-scheduler. Thus, we will move it to the global section under the cinder template and out of the cinderAPI and cinderBackup since they will inherit it. We still need to set the backend_availability_zone in all cinderVolumes except az0 since it will also inherit the new default value. However, the additional line is kept in az0's customServiceConfig to make the pattern easier to see for az0, az1, az2, etc.

Jira: https://issues.redhat.com/browse/OSPRH-11915

@openshift-ci openshift-ci bot requested review from abays and cjeanner December 3, 2024 13:38
@openshift-ci openshift-ci bot added the approved label Dec 3, 2024
@fultonj fultonj force-pushed the OSPRH-11915 branch 2 times, most recently from 923d166 to 572aacf Compare December 3, 2024 13:51
@fultonj fultonj requested review from krcmarik and sbekkerm and removed request for cjeanner December 3, 2024 14:48
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this if we've tested it somewhere

The customServiceConfig for cinder in the DCN DT is used
to set the storage_availability_zone. We wish to do this
for all Cinder services in the default site (`az0`), not
just for cinderAPI or cinderBackup as the AZ was missing
from the cinder-scheduler. Thus, we will move it to the
global section under the cinder template and out of the
cinderAPI and cinderBackup since they will inherit it.
We still need to set the backend_availability_zone in
all cinderVolumes except az0 since it will also inherit
the new default value. However, the additional line is
kept in az0's customServiceConfig to make the pattern
easier to see for az0, az1, az2, etc.

Jira: https://issues.redhat.com/browse/OSPRH-11915

Signed-off-by: John Fulton <[email protected]>
@fultonj
Copy link
Contributor Author

fultonj commented Dec 12, 2024

This has passed a CI test and is ready to merge.

Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj, krcmarik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f03c28f7c56842469dd57a231c657270

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-dcn SUCCESS in 3m 29s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5576566 into openstack-k8s-operators:main Dec 12, 2024
7 checks passed
@fultonj
Copy link
Contributor Author

fultonj commented Dec 12, 2024

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@fultonj: new pull request created: #463

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

softwarefactory-project-zuul bot added a commit that referenced this pull request Dec 12, 2024
…59-to-18.0-fr1

[18.0-fr1] Set Cinder customServiceConfig globally in DCN DT

This is an automated cherry-pick of #459
/assign fultonj

Reviewed-by: Andrew Bays <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants