Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0-fr1] OSASINFRA-IPV6 DT #475

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[18.0-fr1] OSASINFRA-IPV6 DT #475

merged 1 commit into from
Jan 20, 2025
+1,706 −2

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #421

/assign rlobillo

@rlobillo
OSASINFRA-IPV6 DT
12bf649 
A DT for deploying OpenShift on OpenStack using IPV6.

This DT is inspired on the existing OSASINFRA DT but configuring the
IPV6 endpoints.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2025
Merged
@openshift-ci openshift-ci bot requested review from cjeanner and leifmadsen January 17, 2025 10:29
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a693875782d941138010ec31931e4832

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 46s
❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 4m 34s

@abays
Copy link
Contributor

abays commented Jan 20, 2025

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a693875782d941138010ec31931e4832

✔️ noop SUCCESS in 0s ✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 46s ❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 4m 34s

It looks like whatever network-values the job is generating to use with kustomize build examples/dt/osasinfra-ipv6/control-plane/nncp are not quite right. Just clone this fork/branch locally and testing kustomize build examples/dt/osasinfra-ipv6/control-plane/nncp with the defaults works just fine.

@rlobillo
Copy link
Contributor

Build failed (check pipeline). Post recheck (without leading slash) to rerun all jobs. Make sure the failure cause has been resolved before you rerun jobs.
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a693875782d941138010ec31931e4832
✔️ noop SUCCESS in 0s ✔️ rhoso-architecture-validate-osasinfra SUCCESS in 3m 46s ❌ rhoso-architecture-validate-osasinfra-ipv6 FAILURE in 4m 34s

It looks like whatever network-values the job is generating to use with kustomize build examples/dt/osasinfra-ipv6/control-plane/nncp are not quite right. Just clone this fork/branch locally and testing kustomize build examples/dt/osasinfra-ipv6/control-plane/nncp with the defaults works just fine.

Hello Andrew, thanks for checking. It failed because the depending patch was still on review. It has been merged now so recheck will work, let's see.

@rlobillo
Copy link
Contributor

recheck

abays
abays approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jan 20, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/1ddef329fc54442aba6728fe8bda3e1c

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-osasinfra SUCCESS in 5m 02s
✔️ rhoso-architecture-validate-osasinfra-ipv6 SUCCESS in 5m 01s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6e3ee90 into openstack-k8s-operators:18.0-fr1 Jan 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays approved these changes

@cjeanner cjeanner Awaiting requested review from cjeanner

@leifmadsen leifmadsen Awaiting requested review from leifmadsen

Assignees

@abays abays

@rlobillo rlobillo

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @abays @rlobillo