Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimaps Go Black When Zoomed Out on Specific Backgrounds (OpenTopoMaps, Bing Maps Aerial, Mapbox Satellite) #10653

Open
Darshit42 opened this issue Jan 5, 2025 · 5 comments
Labels
bug A bug - let's fix this!

Comments

@Darshit42
Copy link

URL

No response

How to reproduce the issue?

When using minimap functionality, the minimap turns completely black under the following conditions:

  1. select a background such as OpenTopoMaps, Bing Maps Aerial, or Mapbox Satellite is selected
  2. zoom out on the map

Screenshot(s) or anything else?

Screen-Recording.1.mp4

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.30.4

Which browsers are you seeing this problem on?

Chrome

@Darshit42
Copy link
Author

i think issue is it fails to render the minimap after a certain limit , im working on this , if there's something else causing feel free to leave a comment

@tyrasd tyrasd added the bug A bug - let's fix this! label Jan 7, 2025
@tyrasd
Copy link
Member

tyrasd commented Jan 7, 2025

My initial guess would be that the minimap may not properly respect the minimum zoom level property of the respective background layers. @Darshit42 feel free to investigate this.

@Darshit42
Copy link
Author

i am investigating it, i will checkout it and if im successful i will make a pr

@Darshit42
Copy link
Author

Darshit42 commented Jan 8, 2025

@tyrasd
image

this is background_source.js

i have made changes in this function so that the zoom size is always valid , is this correct? or do i need to make some other changes too?

this is the output before minimap was not able to render after 200km

image

if everything's fine should i raise a pr?

@Darshit42
Copy link
Author

Darshit42 commented Jan 14, 2025

@tyrasd i tried running npm test and there are 4 errors which are all due to zooming out which causes minimap to go black , therefore when i fix the issue and remove the upper bound on the zoom extent these errors occur

image

image

should i change test cases to fix these errors??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

No branches or pull requests

2 participants