-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update legacy lexers #76
Comments
Is this check list kept up-to-date? |
Yes, I try to keep it up to date. |
Hit the Haskell lexer in #123 |
It seems to me that many of them have been modernized already:
So, to be exact, when trying to find a lexer, where I could help with fixing this bug, I haven’t found a one, which wouldn’t be modern, and |
The lexers you link have not been migrated according to the migration guide in this issue's original post (https://orbitalquark.github.io/scintillua/api.html#migrating-legacy-lexers). For example, consider the actionscript.lua lexer you linked to. It starts with
but applying the migration steps would yield
(note the lack of whitespace rule, which is now implicit). There may be some confusion regarding object-oriented lexers vs. migrated lexers. For that I am sorry. I hope the migration guide I linked to makes it clear though. |
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
References: orbitalquark#76
Scintillua 6.0 considers lexers from Scintillua 5.x to be legacy lexers. While legacy lexers should still function properly, they ought to be migrated using this migration guide.
In addition to the steps outlined in the migration guide, programming language lexers should ideally distinguish between functions, builtin functions, and methods. They should also distinguish between constants and builtin constants, and variables and builtin variables. For example, the Lua lexer does so here and here. The Makefile lexer does so here.
Lexers that use custom tokens should try and pick from the updated list of tags. If that is not possible/reasonable, it may be worth considering adding to that list. Otherwise, it should remain a custom tag name and a style should be set for it for all themes in themes/. That will signal that applications will need to add styling for it.
The following unchecked Scintillua lexers still need to be migrated:
The text was updated successfully, but these errors were encountered: