Django Commons
Replies: 2 comments 8 replies
-
It's been smooth! I tweaked some of the base GA scripts a little. I have one that checks to see if the CoC has updated once a week and if it has it opens a PR to pull in the new CoC. I did this because if it changes I wanted some automatic notification as to what the changes were. I also tweaked the release GA a bit but gave up trying to get it to do what I want it to do which is run my tests first and only publish if everything passes. There seems to be some conditional flow control limitations wrt to how a GA can run other workflows.
Not anything urgent! It'd be nice if the CoC check could be a push (webhook) instead of a pull but ¯\(ツ)/¯
I'm self conscious about how long the CI runs on this repo (~20 minutes). There's no way to avoid starting up a bunch of python subprocesses to test this library because of what it is. Every time this happens all the pytest/coverage stuff has to bootstrap which takes awhile so there's not much more efficiency I can wring out of it. I'm worried it might be an unnecessarily large hog on the actions quota. I'm not sure how concerned I should be about this. I'm considering disabling CI on commits and only running it on PRs. |
Beta Was this translation helpful? Give feedback.
-
That's an interesting idea! I do hope that if we make a change to the CoC there'd be a discussion post here tagging all members. But we haven't run into that use case, so I'm not sure we can promise that.
For now, this isn't a problem. Public repos don't have quotas as far as I know. But it's nice to reduce run-times for the environment 💚 |
Beta Was this translation helpful? Give feedback.
-
I noticed that GitHub workflow, it is very cool! However, I think it is a bit of overkill, a simple link to the django-commons CoC would suffice. |
Beta Was this translation helpful? Give feedback.
-
|
I thought about just linking, but I'm a pedant and not having the full CoC available when clicking the CoC tab bothered me. And also, I wanted an automagic notification with a nice diff to see when and what any updates were. Not because I don't trust the updates, mostly because I figure if there is an update it was precipitated by something and I'd like the push to figure out what that was. |
Beta Was this translation helpful? Give feedback.
-
|
@cunla @williln @tim-schilling Just ran into an issue, but it may be user error. I'm trying to create a fine grained access token for django-typer but it seems I do not have the permissions to do so. Usually the way I do this for a repo owned by an organization is Profile -> Organizations -> django-commons -> settings, but the settings link is not available to me for django-commons. And django-typer is not available to me in the token drop down under my own profile's settings. Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
Ni @bckohan, what about if you go to: https://github.com/settings/personal-access-tokens/new Can you create PAT with access to django-typer there? |
Beta Was this translation helpful? Give feedback.
-
|
no, I no longer own the repo so it doesnt show up in the drop down 
|
Beta Was this translation helpful? Give feedback.
-
|
above you have resource owner... you can't select django-commons? |
Beta Was this translation helpful? Give feedback.
-
|
To clarify, further up on the screen there's a resource owner dropdown. It defaults to you. It would need to be django-commons which should then show django commons repo's you're an admin for (which includes django-typer). |
Beta Was this translation helpful? Give feedback.
-
|
!! thankyou! what a terrible UI haha |
Beta Was this translation helpful? Give feedback.
-
Hi @django-commons/django-typer! I wanted to take a moment and check in with you about how the transition to Django Commons has been.
If you'd like to chat with us privately, our email is [email protected]. Thanks!
Beta Was this translation helpful? Give feedback.
All reactions