Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Testing Coverage for Chainlink Feeds and Factory #151

Open
TomasCImach opened this issue Jan 17, 2024 · 1 comment
Open

Enhance Testing Coverage for Chainlink Feeds and Factory #151

TomasCImach opened this issue Jan 17, 2024 · 1 comment
Assignees

Comments

@TomasCImach
Copy link
Member

          The changes proposed here tests the cases with an already deployed feed factory and feed. While this is very helpful and enable us to test on Arbitrum mainnet environment with the actual feeds that we're using, it will not catch the future changes made on chainlink feeds and fatory.

We should add test-deployed feeds as well.
@EperezOk @magnetto90 please comment on this.

Originally posted by @TomasCImach in #133 (comment)

@EperezOk
Copy link
Contributor

If we are going to write new tests, I think we should do that in Foundry. However, unless we plan on making changes to the feeds/factory, I don't think this is a priority right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants