Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible 63/64 vulnerability for liquidation callback #211

Open
arthurka-o opened this issue Jan 7, 2025 · 0 comments
Open

Possible 63/64 vulnerability for liquidation callback #211

arthurka-o opened this issue Jan 7, 2025 · 0 comments

Comments

@arthurka-o
Copy link
Contributor

From gas report, overlayMarketLiquidateCallback in ShivaV1 consumes maximum of 123036 gas. liquidate without a callback consumes around 181792 (not enough data for minimum value yet)
So to abuse 63/64, overlayMarketLiquidateCallback should consume more than 181792 * 64 = 11.634.688 which is x94 of the current max.

We need to keep in check gas consumption of overlayMarketLiquidateCallback (should NOT go up too much), and liquidate (should NOT go down too much)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant