Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No messages generated for shields/energy in multiplayer for picking up a spew at the same time it spawns #158

Open
roncli opened this issue Sep 10, 2021 · 1 comment
Labels
bug Something isn't working Multiplayer General multiplayer issues. needs more info There is not enough information to reproduce the issue.

Comments

@roncli
Copy link
Member

roncli commented Sep 10, 2021

Some players believe this also means you are NOT picking up the items. I'm not sure we have seen that in the wild yet, so more information is needed on this.

@roncli roncli added bug Something isn't working Multiplayer General multiplayer issues. labels Sep 13, 2021
@roncli roncli added this to the v0.5.0 milestone Sep 13, 2021
@roncli roncli self-assigned this Sep 13, 2021
@roncli roncli removed this from the v0.5.0 milestone Sep 14, 2021
@roncli roncli added the needs more info There is not enough information to reproduce the issue. label Sep 14, 2021
@roncli roncli removed their assignment Sep 14, 2021
@roncli
Copy link
Member Author

roncli commented Dec 19, 2021

This is the result of a positional disagreement between client and server. The client thinks it picked up the powerup, but the server does not. The client does a "fake pickup", giving the sound and removing it from the game, and then waits for the server to give it the message that you picked it up, but that message never happened. The powerup remains there to be picked up, but the client who thought they picked it up and didn't can't actually see it.

The intention is for the player to hear a pickup the moment they run over it, and the code assumes that positions will always be perfect... which they are not. Is the right answer to make it 100% server side controlled? Keep the powerup in the level until the server says it's picked up? Or keep it as is? Not sure on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Multiplayer General multiplayer issues. needs more info There is not enough information to reproduce the issue.
Projects
None yet
Development

No branches or pull requests

1 participant