Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview of images file://xxx #945

Open
2 tasks done
jgreffe opened this issue Nov 5, 2024 · 2 comments
Open
2 tasks done

Preview of images file://xxx #945

jgreffe opened this issue Nov 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jgreffe
Copy link

jgreffe commented Nov 5, 2024

Before Submitting Your Feature Request

  • Check that there isn't already a similar feature request to avoid creating a duplicate.
  • I have seen the FAQ.

Problem

When copying a reference to an image file with the file:// protocol, something like file:///tmp/my-image.png, Maccy doesn't display a preview of this image.
I'm not sure it's achievable?

This has been observed using Monosnap: https://apps.apple.com/fr/app/monosnap-screenshot-editor/id540348655

Solution

file://xxx references of images should display a preview

@jgreffe jgreffe added the enhancement New feature or request label Nov 5, 2024
@p0deje
Copy link
Owner

p0deje commented Nov 5, 2024

This is by design. When you copy a file, we don't have access to it and I am not sure Maccy should attempt to load the file and show its contents. We don't really want to grow Maccy memory for file loading and I could pose security issues as well, when loading untrusted input.

@p0deje p0deje closed this as completed Nov 22, 2024
@p0deje p0deje closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
@paragkatoch
Copy link

I tried using the ‘copy to clipboard’ shortcut action on images, but it’s not showing the preview.

@p0deje How about accessing only for images, possibly no security threat and maybe a file size limit for preview?

@p0deje p0deje reopened this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants