Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable h-scroll during v-scroll and vice versa #19

Closed
cytopia opened this issue May 11, 2016 · 12 comments
Closed

Disable h-scroll during v-scroll and vice versa #19

cytopia opened this issue May 11, 2016 · 12 comments

Comments

@cytopia
Copy link

cytopia commented May 11, 2016

Is it possible to disable horizontal scrolling while you scroll vertically and vice versa?
This seems to be the standard behavior on OSX with two-finger scroll and is kind of easier.

It happens a lot to me, if I am using half a browser width and pages have a big horizontal scroll, that once I scroll up/down I also move left/right by accident.

Any thoughts on this?

@p2rkw
Copy link
Owner

p2rkw commented May 12, 2016

Are you sure you using current master?
It was fixed in #17

@cytopia
Copy link
Author

cytopia commented May 12, 2016

I definitely have the above mentioned commit (when I check via git log) in your repo I compiled from source .

Anything else I can check? Any debug option I can turn on?

@p2rkw
Copy link
Owner

p2rkw commented May 12, 2016

In this case I will have to first reproduce and then debug it. Please post your configuration (as described in readme)

@rmanne
Copy link

rmanne commented Jan 24, 2017

I still have this issue, was this resolved?

Output of xinput --list-props 12 (bcm5974):
xinputprops.txt

My configuration (not minimal) 10-mtrack.conf:
10-mtrack.txt

I'm on the latest commit (eb3b9c3...).

@p2rkw
Copy link
Owner

p2rkw commented Jan 27, 2017

Is h-scroll triggered only at the bottom of the scrolled window? Which button events are generated (xinput --test )?

@rmanne
Copy link

rmanne commented Jan 27, 2017

No, when v-scrolling, h-scroll triggers whereever, even in the center of a webbrowser page . When scrolling up for example, it's some button press/release 5 intersperced with some button press/release 6. Partial output here: log.txt

@p2rkw
Copy link
Owner

p2rkw commented Jan 28, 2017

Could you please also attach output of xinput list --long 12. I'm still struggling with reproduction.
Does this horizontal movement have same speed(distance) as vertical, or is it rather occasionally?

@rmanne
Copy link

rmanne commented Jan 28, 2017

To be completely honest, I thought it was initially it was the "default" effect. It's usually smooth and perfectly consistent. It jitters a lot when I move two fingers in a circle, but if it's just slight movements, mostly vertical, it's perfectly smooth. I made a gif to show the interaction:
output

Here's the output of xinput list --long 12:
log.txt

@p2rkw
Copy link
Owner

p2rkw commented Jan 29, 2017

So, this is how SmoothScroll(aka. pixel perfect scroll) works: what we observe is just "inaccurate" v-scroll.
Looks like I will have to add another configuration variable to ignore "perpendicular" movement while other is active.

@p2rkw
Copy link
Owner

p2rkw commented Jan 29, 2017

Please check how it behave with this commit: fe08710 before I push it to master.

@rmanne
Copy link

rmanne commented Jan 30, 2017

Solid, it works.

p2rkw added a commit that referenced this issue Jan 30, 2017
…xis at time.

Don't emit h-scroll events during v-scroll.
Fixes github #19.
@p2rkw
Copy link
Owner

p2rkw commented Jan 30, 2017

Slightly modified fix landed on master.

@p2rkw p2rkw closed this as completed Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants