Missing Debit Card Networks in CardBrand.php

[james-ingold]

CardBrand.php seems to be missing some debit card networks, specifically:

Interlink, Accel, NYCE, and Pulse.

Maestro and Star are currently included in CardBrand.php.

This can cause an issue when checking for a valid value.

https://github.com/paypal/PayPal-PHP-Server-SDK/blob/main/src/Models/CardBrand.php#L21
https://github.com/paypal/PayPal-PHP-Server-SDK/blob/main/src/Models/CardBrand.php#L112

[LeonarthusMectus]

Hey @james-ingold

I'm sorry for the delay in responding here. I'm trying to go through all the issues more regularly and make sure things are progressing. In addition to continuing work on your other reports (I have various tickets open with API teams on most of them), I wanted to try and clarify this one so I can work with the correct teams here.

I looked at the docs and didn't note the specific brands you mentioned as missing, so I'm curious if these are values you're actually receiving, or values you plan to receive based on payment methods being used by your customers.

Some context, as part of the work around this SDK, we're working quite hard to significantly improve the API documentation correctness and identify what I suppose you could consider UB in the API? The clarification here would help tremendously.

[james-ingold]

Hey there, yes these are actual values that caused an error because they were missing from CardBrand.php during debit card processing. I had to add them to CardBrand.php to make sure they got through. Can check my fork that I'm running in production for the changes: https://github.com/james-ingold/PayPal-PHP-Server-SDK

[LeonarthusMectus]

Thanks for confirming, that's what I suspected. I wanted to be positive as it gives us more concrete details. I'm tracking down the right folks here to get a complete list of values for a few properties you've run into, including this one. I did take a look at your fork & patches, which make sense given the few issues you've run into.

I'm hoping to get a complete list so we don't run into this issue again for others in differing regions as well given there could be different card types you may not see, but others would.

As always, please keep letting us know if you find any issues. It may seem that we're not making changes or updating the SDKs, but full disclosure, each issue you've raised also impacts the docs given the SDKs are built against the same spec, so it's critical we loop in the right teams and get all the details sorted so we can get a proper fix for all impacted sources.