Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "otherwise" in hash_append reference docs #29

Open
Lastique opened this issue Dec 9, 2024 · 1 comment
Open

Missing "otherwise" in hash_append reference docs #29

Lastique opened this issue Dec 9, 2024 · 1 comment

Comments

@Lastique
Copy link
Contributor

Lastique commented Dec 9, 2024

In this section, each item in Effects seems to be an alternative rather than a step in the sequence. I think, in such cases each item should end with "; otherwise". Or better yet, the Effects should start with a preamble like "Performs one of the following actions".

@pdimov
Copy link
Owner

pdimov commented Dec 9, 2024

"Otherwise" implies that they are tried in order, and the first match wins, which isn't currently the case (for the same reason I haven't made tag_invoke "win" over the rest.)

I've found that ambiguities are generally better reported, than arbitrarily settled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants