Skip to content
This repository has been archived by the owner on Jul 7, 2022. It is now read-only.

Latest update breaks the build process #56

Open
biplabbhattacharya opened this issue Apr 29, 2020 · 3 comments
Open

Latest update breaks the build process #56

biplabbhattacharya opened this issue Apr 29, 2020 · 3 comments

Comments

@biplabbhattacharya
Copy link

Hi Team,

I tried using the latest updated version and could not install the requirements.txt file. It seemed to break while doing a pip install on gvar. Error was both on Windows and UNIX.

commit id d194a17 works fine.

Thanks,
BB

@ckoerber
Copy link
Contributor

Hello BB,

To enable fast computations, gvar compiles C code into a Python module. For this reason it requires a compiler and numpy as perquisites. Likely, this was the cause of the error (but it's tough to say without more information).

I've run docker build . for this repo and encountered an error message related to a failed gvar install attempt. It seems that docker build creates a conda environment with numpy bit did not activate it (thus numpy was not present before compilation). Below you can find a suggestion of how to update the Dockerfile to resolve install problems.

FROM continuumio/miniconda3
WORKDIR /chime_sims

# Install gcc for compiling gvar later
RUN apt-get update && apt-get -y install gcc

RUN conda update -yq -n base -c defaults conda
RUN conda create -yq -n chime_sims python=3.7 pip pandas matplotlib scipy numpy seaborn

# Activate new environment which has numpy
RUN echo "source activate chime_sims" > ~/.bashrc
ENV PATH /opt/conda/envs/chime_sims/bin:$PATH

# And install dependencies
COPY ./requirements.txt .
RUN pip install -q -r requirements.txt

Does this resolve the issue?

@biplabbhattacharya
Copy link
Author

I'm working on this with @DebdiptoM

We tried running Dockerfile using docker-compose up and it exited with code 137

Creating network "chime_sims_default" with the default driver
Creating chime_sims_chime_sims_1 ... done
Attaching to chime_sims_chime_sims_1
chime_sims_chime_sims_1 exited with code 137

But we are able to use the instructions in the "More Flexible Way" part of the README file.
Also,would it be possible to checkin the updated Dockerfile(above) into git as the Docker file in the master branch needs to be updated after the gvar changes?

DebdiptoM added a commit to DebdiptoM/chime_sims that referenced this issue May 5, 2020
@DebdiptoM
Copy link

The Dockerfile above works. Requesting @mdbecker to update the Dockerfile in master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants