Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue of very similar runs falsely combining results in summary #61

Open
fmaguire opened this issue Oct 6, 2021 · 0 comments
Open
Labels
bug Something isn't working p0

Comments

@fmaguire
Copy link
Member

fmaguire commented Oct 6, 2021

If the exact same tool is run with different settings (but all the other metadata stays the same such as version) summarize falsely combines them e.g., running RGI on contigs and reads, hamronizing each output, and them combining them in a summary will end up with an interactive summary that both RGI contig and RGI-bwt results are from the same simple run of RGI.

Solution: Summarize should try and treat each file separately and assign a new config # if multiple hAMRonized files are supplied

https://github.com/pha4ge/hAMRonization/blob/master/hAMRonization/summarize.py#L16

@fmaguire fmaguire changed the title Add --config flag Fix issue of very similar runs falsely combining results in summary Oct 6, 2021
@cimendes cimendes added the bug Something isn't working label Oct 12, 2021
@cimendes cimendes added the p0 label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0
Projects
None yet
Development

No branches or pull requests

2 participants