Could we streamline the metadata section of our ADVS peds template? #94
Replies: 2 comments
-
David ideas shared from email which we can discuss at team meeting: I agree with the first discussion point: user coding should be streamlined. My cdcanthro function requires just one line of code, such as WHO's 'anthro' function on CRAN works similarly (1 line for the user). Maybe the long data set could be made into a wide dataset, ALL calculations (weight, height, BMI, etc) performed, concerverted back to long, and then merged/joined with the original data. (There are very fast pivot and join functions in the 'collapse' packages; these are much faster than the dplyr equivalents. |
Beta Was this translation helpful? Give feedback.
-
The current way of having the metadata code included in the template was chosen by the {admiralpeds} team for transparency reasons :
It will currently be left as it is until further feedback. |
Beta Was this translation helpful? Give feedback.
-
When implementing this for Roche, we got some feedback to consider:
I explained the rationale to have it transparently laid out in the template is that users could actually choose to replace the CDC and WHO files with any growth charts they like (e.g. there's also some given by International Obesity TaskForce) so we wanted to show openly how we structure these files so that they could equally easily create their own if they ever needed. Although maybe if we had it in a function or provided dataset instead though its not so bad, as we could instead just explain it all in documentation.
Beta Was this translation helpful? Give feedback.
All reactions