Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing Button order #16395

Closed
astares opened this issue Apr 3, 2024 · 4 comments
Closed

Confusing Button order #16395

astares opened this issue Apr 3, 2024 · 4 comments
Milestone

Comments

@astares
Copy link
Member

astares commented Apr 3, 2024

In Pharo up to version 11 one was able to

  • confirm dialogs with a button on the left side (which follows european reading order to have first primary action on left)
  • cancel dialogs with a button on the right side
    and which is the usual way for platforms like LINUX and WINDOWS.

image

Now in Pharo 12 it looks like the confirmation has been changed to do it exactly the other way around.

  • cancel dialogs with a button on the left side
  • confirm dialogs with a button on the right side
    which seems to align with Apples macOS style.

image

**This is breaks the flow, is now really strange and painful for every developer used to the other platforms and the previous "clicking" style of Pharo. **

Unfortunately there is no setting to get back to the original situation for those who are used to it while allowing the current order for people who are used to Apple.

For the label area of windows Pharo offers already a setting to distinguish between macOS and Linux/Windows style.

image

Havent checked how the new dialog is done - but I expect it to be done with Spec2. So maybe it is a reusable part so such a setting and button order switch could be provided centrally and in a reusable way.

@astares astares added this to the 12.0.0 milestone Apr 3, 2024
@jecisc
Copy link
Member

jecisc commented Apr 3, 2024

Hi,

The order of button was not always the same in all Pharo applications and this is something we want to improve.
For Pharo 12 a first step that Estaban did was to make sure the order was the same for all the Pharo tools.

The long term goal would be to add a configuration indeed once we will have only one way used to declare an action button and a cancel button

@astares
Copy link
Member Author

astares commented Apr 3, 2024

We still have a mixture in P12 - some of the dialogs use the previous order:
image

I understand and appreciate the progress to convert the dialogs - so it is a WIP.

@Ducasse
Copy link
Member

Ducasse commented Dec 17, 2024

I will close this issue and we can reopen it in spec.

@astares
Copy link
Member Author

astares commented Dec 17, 2024

I opened a Spec issue for it: pharo-spec/Spec#1684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants