Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend tests should not message the widget #1700

Open
tinchodias opened this issue Jan 17, 2025 · 0 comments
Open

Backend tests should not message the widget #1700

tinchodias opened this issue Jan 17, 2025 · 0 comments

Comments

@tinchodias
Copy link
Contributor

Tests in Spec2-Backend-Tests should query the state of the widget through adapter's API. Most tests are fine, but some of them make assumptions on the widget's API, and send messages to the widget that only Morphic backend understand.

I collected this list:

  • 8 tests in SpGridLayoutAdapterTest send self presenter adapter widget submorphs, assuming backend is Morphic
  • SpCheckboxAdapterTest>>#testChangingLabelAffectTheWidget
  • SpLabelAdapterTest>>#testBackgroundColorChangesColor
  • SpNotebookAdapterTest>>#testSelectingPageShouldAnnounceChangeEvent (sends self adapter widget tabSelectorMorph)
  • SpRadioButtonAdapterTest>>#testChangingLabelAffectTheWidget (sends self widget label)
  • 3 tests in SpTextAdapterTest send presenter adapter widget textArea editingState undoManager

I extracted those candidates by exploring the senders of widget in the Spec2-Backend-Tests package:

Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant