Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message when running composer commands that The Update Frame is being used #121

Open
tedbow opened this issue Jul 17, 2024 · 3 comments

Comments

@tedbow
Copy link
Contributor

tedbow commented Jul 17, 2024

Add message when running composer commands that The Update Framework is being used and it will affect performance.
I think we just need 1 message per operation and just list the repos that are being protected.

This is important because people who are using TUF in UI like Drupal AutoUpdates might not be aware it runs on the Composer level and will therefore affect Composer operations on the command line also. They might just think Composer is slightly slower for no obvious reason

@ergonlogic
Copy link
Contributor

I opened a PR (#125) to resolve this. It's pretty basic.

FYI, $io->info(...) and $io->notice(...) don't seem to print anything at the default verbosity. So I borrowed the technique used in composer-patches (ie. $io->write('<info>...</info>'))

I also moved the "This may impact performance" message from the individual repos, to the message that the plugin is active, since I think we only need to mention that once.

@ergonlogic
Copy link
Contributor

This seems to have failed some tests. I didn't update the tests, since they run under -vvv, and so should still print the info messages, afaict.

ergonlogic added a commit to consensus-enterprises/composer-integration that referenced this issue Oct 28, 2024
@ergonlogic
Copy link
Contributor

The test was only checking for output in STDERR. Now we also check STDOUT, when relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants