Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error modal to handle timedout. #802

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Update error modal to handle timedout. #802

merged 2 commits into from
Dec 20, 2024

Conversation

cancan101
Copy link
Contributor

@cancan101 cancan101 commented Dec 19, 2024 •
edited
Loading

Currently a timeout given this unhelpful message:
image

timedout is mentioned here: https://cdn.sencha.com/ext/commercial/4.2.2/docs/source/Connection.html

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@robertSt7 robertSt7 self-assigned this Dec 20, 2024
@robertSt7 robertSt7 added this to the 1.8.0 milestone Dec 20, 2024
@robertSt7 robertSt7 merged commit 58643e5 into pimcore:1.x Dec 20, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
@robertSt7
Copy link
Contributor

@cancan101 Thanks for making the error message better

@cancan101 cancan101 deleted the feature/handle-timeout-log branch December 20, 2024 17:14
@herbertroth herbertroth modified the milestones: 1.8.0, 2.0.0 Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@robertSt7 robertSt7

Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cancan101 @robertSt7 @herbertroth