Fix asset preview performance #804
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
cuca24
changed the title
|
I have read the CLA Document and I hereby sign the CLA |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the performance of asset preview routes are still very poor with this fix: https://github.com/pimcore/admin-ui-classic-bundle/pull/767/files for non admin users.
For example total number of assets: 500k it takes about ~13s for select query and additional ~13s for additional count query which barely avoids timeout of 30 seconds.
@kingjia90 i added also call to grid helper functions for assets preview, which makes the performance the same for listing and preview. Is there any reason why we should not use it for preview like i did in PR?