Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site broken after every Elementor update; Add flush cache after update option #272

Open
ghost opened this issue Aug 9, 2022 · 4 comments

Comments

@ghost
Copy link

ghost commented Aug 9, 2022

Describe the bug
Website's styling is broken after every auto-update of Elementor or Elementor pro (and likely other page builder plugins) because the cache doesn't flush upon plugin updates.

To Reproduce
Steps to reproduce the behavior:
1: Install Elementor, create a page with it
2: Set Elementor to auto-update
3: Wait for it to auto-update
4: Visit the page (with Cachify enabled, obviously)
5: See broken page

Expected behavior
It should flush the cache after every plugin update because it is very likely scripts and styles are getting updated.

System (please complete the following information):
Any

Additional context
Perhaps adding an option to flush the cache after plugin/theme/core updates would be prudent to resolve the issue.

@ghost ghost changed the title Site broken after every Elementor update; Add flush cache after plugin update option Site broken after every Elementor update; Add flush cache after update option Aug 9, 2022
@Zodiac1978
Copy link
Member

Zodiac1978 commented Aug 9, 2022

You can use the cachify_flush_cache_hooks Filter to add this. We decided against it, because not every plugin needs this.
Maybe we need to revise this decision...

@ghost
Copy link
Author

ghost commented Aug 9, 2022

Alright, giving that a go on "upgrader_process_complete". Thanks for that and yes, I definitely think it should flush on updates. It's not hurting anyone but it may break many websites so the needs outweigh the cost by far imho.

@Zodiac1978
Copy link
Member

WP Rocket displays a warning with an info about the detected plugin update. Maybe this could be a first step.

@ghost
Copy link
Author

ghost commented Aug 9, 2022

That would require me to be on the dashboard to see that warning. Having it on auto-update (which I usually don't but many people do) leaves me unaware of a broken site. Having to log in to clear the cache manually every time defeats the purpose of auto-upating altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant