Show scroll lock and pause as options for built-in keyboards #140
Comments
ids1024
added a commit
that referenced
this issue
Jun 27, 2022
'Non-US \' is not listed, since the PS/2 keycode for that is the same as 'Backlash'. The UI around non-US layouts could be improved, but that's already an issue and this at least makes it possible to set this mapping. This does not add the `PAUSE` and `SCROLL_LOCK` keycodes that have been added to EC. At least with `PAUSE`, this is complicated since it won't work on older firmware, and we should probably test for that (#140). Fixes #127.
ids1024
added a commit
that referenced
this issue
Jul 13, 2022
'Non-US #' is not listed, since the PS/2 keycode for that is the same as 'Backlash'. The UI around non-US layouts could be improved, but that's already an issue and this at least makes it possible to set this mapping. This does not add the `PAUSE` and `SCROLL_LOCK` keycodes that have been added to EC. At least with `PAUSE`, this is complicated since it won't work on older firmware, and we should probably test for that (#140). Fixes #127.
ids1024
added a commit
that referenced
this issue
Jul 13, 2022
'Non-US #' is not listed, since the PS/2 keycode for that is the same as 'Backlash'. The UI around non-US layouts could be improved, but that's already an issue and this at least makes it possible to set this mapping. This does not add the `PAUSE` and `SCROLL_LOCK` keycodes that have been added to EC. At least with `PAUSE`, this is complicated since it won't work on older firmware, and we should probably test for that (#140). Fixes #127.
ids1024
added a commit
that referenced
this issue
Mar 21, 2023
* Handle firmware version `0.12.20`, as used in system76/qmk_firmware#14 (which I think was released?) * Don't mutate header files. * Map names to match what previous version used - Need to make sure everything, including `RESET`/`BOOT`, is working as expected, with both versions. * Add `\n` to end of generated json files. * Fix behavior without `--override`. This still avoids updating the default keymaps for builtin keyboards pending #140.
13r0ck
pushed a commit
that referenced
this issue
Mar 23, 2023
* Handle firmware version `0.12.20`, as used in system76/qmk_firmware#14 (which I think was released?) * Don't mutate header files. * Map names to match what previous version used - Need to make sure everything, including `RESET`/`BOOT`, is working as expected, with both versions. * Add `\n` to end of generated json files. * Fix behavior without `--override`. This still avoids updating the default keymaps for builtin keyboards pending #140.
13r0ck
pushed a commit
that referenced
this issue
Mar 23, 2023
* Handle firmware version `0.12.20`, as used in system76/qmk_firmware#14 (which I think was released?) * Don't mutate header files. * Map names to match what previous version used - Need to make sure everything, including `RESET`/`BOOT`, is working as expected, with both versions. * Add `\n` to end of generated json files. * Fix behavior without `--override`. This still avoids updating the default keymaps for builtin keyboards pending #140.
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These are already available on Launch.
system76/ec#225 and system76/ec#229 added these bindings, and included them in default layouts.
PAUSEat least is complicated because it won't work on older firmware, so it would need some way to test that the firmware supports it...The text was updated successfully, but these errors were encountered: