Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Non-US #" and "Non-US \" symbols not available on built-in System76 laptop keyboards #127

Open
wagnerck opened this issue Mar 7, 2022 · 3 comments · May be fixed by #141
Open

"Non-US #" and "Non-US \" symbols not available on built-in System76 laptop keyboards #127

wagnerck opened this issue Mar 7, 2022 · 3 comments · May be fixed by #141

Comments

@wagnerck
Copy link

wagnerck commented Mar 7, 2022

The two key options "Non-US #" and "Non-US " are not available when remapping the built-in keyboards on System76 laptops running the open EC firmware. A customer (who is trying to configure his lemp10 to work with a German keyboard layout) described the issue and I was able to confirm on an oryp6.

Since our laptops only ship with US keyboard layouts and we do have a lot of European customers, this seems like it could be very helpful to enable on the EC laptops, if possible. I'm unsure if this would require an update to the EC firmware or not.

Screenshot from an oryp6:

image
@ids1024
Copy link
Member

ids1024 commented Mar 7, 2022

It seems in ec/src/common/include/common/keymap.h, this is K_INT_1 and K_INT_2, but K_INT_2 is the same as K_BACKSLASH. I think that's a quirk with how PS/2 works. I guess to actually distinguish those it needs to use PS/2 scancode set 3 rather than set 2?

Don't know if @crawfxrd has any ideas about this.

@jackpot51
Copy link
Member

@ids1024 selecting a proper layout like German will make the backslash keycode do the right thing. We could expose K_INT_1 though.

@ids1024
Copy link
Member

ids1024 commented Mar 7, 2022

Yeah, we should at least expose K_INT_1. I guess the duplicate keycode isn't a problem since that ANSI key doesn't exist on the ISO layout, but it's a bit funny to expose clearly through the UI, particularly since it differs from how USB/Launch works.

I guess it's something to think about if we add support in the future for using different layouts in the Configurator (so it can show the German meanings of keys, for instance, rather than US). Probably something we'd want good support for if/we we release an ISO variant of Launch.

ids1024 added a commit that referenced this issue Jun 27, 2022
@ids1024
feat: 'Non-US #' on builtin keyboards
301d5c2 
'Non-US \' is not listed, since the PS/2 keycode for that is the same as
'Backlash'. The UI around non-US layouts could be improved, but that's
already an issue and this at least makes it possible to set this
mapping.

This does not add the `PAUSE` and `SCROLL_LOCK` keycodes that have
been added to EC. At least with `PAUSE`, this is complicated since it
won't work on older firmware, and we should probably test for that
(#140).

Fixes #127.
@ids1024 ids1024 linked a pull request Jun 27, 2022 that will close this issue
Open
ids1024 added a commit that referenced this issue Jul 13, 2022
@ids1024
feat: 'Non-US \' on builtin keyboards
c0961c3 
'Non-US #' is not listed, since the PS/2 keycode for that is the same as
'Backlash'. The UI around non-US layouts could be improved, but that's
already an issue and this at least makes it possible to set this
mapping.

This does not add the `PAUSE` and `SCROLL_LOCK` keycodes that have
been added to EC. At least with `PAUSE`, this is complicated since it
won't work on older firmware, and we should probably test for that
(#140).

Fixes #127.
ids1024 added a commit that referenced this issue Jul 13, 2022
@ids1024
feat: 'Non-US \' on builtin keyboards
b751d1f 
'Non-US #' is not listed, since the PS/2 keycode for that is the same as
'Backlash'. The UI around non-US layouts could be improved, but that's
already an issue and this at least makes it possible to set this
mapping.

This does not add the `PAUSE` and `SCROLL_LOCK` keycodes that have
been added to EC. At least with `PAUSE`, this is complicated since it
won't work on older firmware, and we should probably test for that
(#140).

Fixes #127.
@cozy-isaac cozy-isaac mentioned this issue Aug 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 'Non-US \' on builtin keyboards pop-os/keyboard-configurator
3 participants
@ids1024 @jackpot51 @wagnerck