Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings 'celebrate various events' can't be deselected #602

Closed
user440 opened this issue Aug 27, 2017 · 3 comments
Closed

Settings 'celebrate various events' can't be deselected #602

user440 opened this issue Aug 27, 2017 · 3 comments
Labels

Comments

@user440
Copy link
Contributor

user440 commented Aug 27, 2017

Operating System Version:
Win7

Popcorn Time Version:
0.3.10 beta build #252

Download date:
today

Expected Behaviour

deselect settings "celebrate various events'

Actual Behaviour

...

Steps to reproduce the behaviour

  1. go to settings and try to click on option 'celebrate various events'
  2. it can't be deselected and window just jumps down for couple of lines
@user440
Copy link
Contributor Author

user440 commented Sep 2, 2017

To fix this edit "settings-container.tpl" file.

Find lines:
<input class="settings-checkbox" name="events" id="cb7" type="checkbox" <%=(Settings.events? "checked='checked'":"")%>>
<%= i18n.__("Celebrate various events") %>

and replace that "cb7" with "cb8". Save and restart.

user440 referenced this issue in user440/popcorn-desktop Sep 2, 2017
cb7 id is used twice so 'celebrate various events' is not changed properly
@user440 user440 closed this as completed Sep 2, 2017
user440 referenced this issue in user440/popcorn-desktop Sep 9, 2017
rfigueroa-zz referenced this issue in rfigueroa-zz/popcorn-desktop Sep 14, 2017
team-pct added a commit that referenced this issue Mar 10, 2018
'celebrate various events' settings - issue #602
@flamber
Copy link

flamber commented Mar 11, 2018

@team-pct This actually overwrote #474 which had already taken cb8, so the problem is the same, but just with a different setting conflict now.

@team-pct
Copy link
Contributor

team-pct commented Mar 11, 2018

fixed cb44e3f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants