Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Review mouse wheel zoom support for macOS #773

Closed
tbouffard opened this issue Oct 15, 2020 · 5 comments · Fixed by #1305
Closed

[FEAT] Review mouse wheel zoom support for macOS #773

tbouffard opened this issue Oct 15, 2020 · 5 comments · Fixed by #1305
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams decision record Track project and architectural decisions enhancement New feature or request
Milestone

Comments

@tbouffard
Copy link
Member

tbouffard commented Oct 15, 2020

Is your feature request related to a problem? Please describe.
In [email protected], on macOS, the zoom can be triggered with both CTRL as for other os but also with CMD.
We only automatically tests with the CTRL way.

Describe the solution you'd like

Decide if we only want to trigger zoom on CMD, only on CTRL (as for other os) or both --> CTRL only (see #773 (comment))

Additional context
During tests of the initial implementation (#734), it seemed that the zoom didn't work on both Firefox and Safari. Tests on Chromium are passing.
Let recheck this --> this is working, see #773 (comment)

@tbouffard tbouffard added enhancement New feature or request BPMN diagram usability Something about the way we can interact with BPMN diagrams labels Oct 15, 2020
@csouchet
Copy link
Member

Mac OS

Firefox

  • CTRL + mouse wheel => OK, but Browser Zoom
  • CMD + mouse wheel => OK, but Browser Zoom

=> Browser Zoom, even the button is zoom/dezoom (cursor position on task)

Safari

  • CTRL + mouse wheel => KO
  • CMD + mouse wheel => KO

Chrome

  • CTRL + mouse wheel => KO
  • CMD + mouse wheel => KO

@csouchet
Copy link
Member

csouchet commented Oct 19, 2020

I think I found why my tests don't work.

Is it normal not to have the navigation & zoom activated in the demo page ?

@tbouffard
Copy link
Member Author

tbouffard commented Oct 19, 2020

The demo page currently uses a bpmn container with a floating size. This doesn't work well with panning and zoom, that's why panning and zoom are not activated in this page and a new page with fixed size container has been created.
See:

[UPDATE] in 0.8.0 version, the demo page has been reworked. zoom and panning are activated by default and correctly work. See #896

@tbouffard
Copy link
Member Author

We have received feedback #1238 (comment) about the magic mouse usage.
In that case, the zoom is not progressive, the scale increases from 1 to 5 (this is an example) without passing by scale 2, 3 and 4
Everything acts as if the mouse sends a lot of mouse wheel events very quickly. A regular mouse sends the events progressively letting the zoom scale change progressively.

@tbouffard tbouffard added the decision record Track project and architectural decisions label May 17, 2021
@tbouffard
Copy link
Member Author

We have decided to only keep the CTRL button to trigger the zoom for now.
We initially decided to use a button in addition to the mouse wheel as we wanted to also support diagram move with mouse interactions (see process-analytics/bpmn-visualization-addons#168). In the future, we may decide to change the way zoom is managed when using the mouse if we don't implement the 'navigation by mouse' feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN diagram usability Something about the way we can interact with BPMN diagrams decision record Track project and architectural decisions enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants