You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Snapshot tests should have low enough tolerance that this change would cause a test to fail. However, simply reducing the shiftThreshold or even switching to the mapbox pixelmatch package caused many false negative failures on CI. This is because rendering on different platforms is different enough that it's sometimes more than just what pixelmatch detects as an antialiasing difference (for example, sometimes rendered text is shifted a pixel down.) We want these to be acceptable differences.
I'm not sure what options we have here, but if anyone has other libraries they want to test, or updates to our custom diff code, I'd love to hear your ideas!
The text was updated successfully, but these errors were encountered:
Most appropriate sub-area of p5.js?
p5.js version
2.0 beta 1
Web browser and version
N/A
Operating system
N/A
Steps to reproduce this
I was just working on #7495, and found that the change I made to
src/shape/custom_shapes.js
line 398 did not cause existing visual tests to change:Snapshot tests should have low enough tolerance that this change would cause a test to fail. However, simply reducing the
shiftThreshold
or even switching to the mapboxpixelmatch
package caused many false negative failures on CI. This is because rendering on different platforms is different enough that it's sometimes more than just whatpixelmatch
detects as an antialiasing difference (for example, sometimes rendered text is shifted a pixel down.) We want these to be acceptable differences.I'm not sure what options we have here, but if anyone has other libraries they want to test, or updates to our custom diff code, I'd love to hear your ideas!
The text was updated successfully, but these errors were encountered: