Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTLinearDensityFit fit validity check isn't accurate #104

Open
evzayas opened this issue Sep 13, 2017 · 0 comments
Open

KTLinearDensityFit fit validity check isn't accurate #104

evzayas opened this issue Sep 13, 2017 · 0 comments
Labels

Comments

@evzayas
Copy link
Contributor

evzayas commented Sep 13, 2017

A fit is performed on the rotate-and-projected spectrum in KTLinearDensityFit, and a parameter fIsValid is set to record whether the fit converged successfully. This boolean is determined by:

TFitResultPtr::IsValid()

but it doesn't always accurately describe the success of the fit. Sometimes fits with STATUS=FAILED or similar obviously bad results still return true, and contaminate what we expect are good fits with nonsense. Perhaps a different method of validating the fit should be used.

@evzayas evzayas added the Defect label Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant