Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding of variables set with set_option #26

Open
nsoblath opened this issue Apr 20, 2018 · 0 comments
Open

Allow overriding of variables set with set_option #26

nsoblath opened this issue Apr 20, 2018 · 0 comments
Assignees

Comments

@nsoblath
Copy link
Member

Currently set_option is defined as:

macro( set_option VARIABLE VALUE )
    set( ${VARIABLE} ${VALUE} CACHE BOOL "" FORCE )
endmacro()

If an option is set with this in a parent package, it will be impossible to override that setting, e.g. from the command line.

We should have two macros, one which allows overriding, and one which doesn't.

The use of these macros should be checked to make sure everything behaves as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant