Add custom message type support #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add custom message type support for the following APIs: publish, signal, share file, subscribe and history.
parfeon
added
status: done
parfeon
requested review from
Xavrax,
seba-aln and
KGronek-Pubnub
as code owners
parfeon
changed the title
Xavrax
approved these changes
Nov 15, 2024
core/pubnub_coreapi_ex.c
Outdated
| result.replicate = true; | ||
| result.meta = NULL; | ||
| result.method = pubnubSendViaGET; | ||
| result.ttl = SIZE_MAX; |
There was a problem hiding this comment.
In pubnub_publish_defopts method description there is mention of all default values, except ttl and custom_message_type. I think it could be worth to add those as well.
There was a problem hiding this comment.
Sure, we can do it :)
Add `pubnub_set_ipv4_connectivity` and `pubnub_set_ipv6_connectivity` functions to make it possible to enforce specific protocol usage. test(message-type): add subscription test for custom message type Modify subscription integration with additional information about custom message type to check parsing.
Xavrax
approved these changes
Nov 20, 2024
Add `pubnub_set_ipv4_connectivity` and `pubnub_set_ipv6_connectivity` to `pubnub_coreapi` to switch preferred connectivity protocol. fix(proxy): add proxy context reset on connection close Make sure that in case of connection close (including because of error) proxy context object will be reset.
Fix issue because of which library with enabled but not configured crypto didn't return message from `pubnub_get_v2`.
KGronek-Pubnub
approved these changes
Nov 25, 2024
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(message-type): add custom message type support
Add custom message type support for the following APIs: publish, signal, share file, subscribe and history.
feat(ipv6): add connectivity setter
Add
pubnub_set_ipv4_connectivityandpubnub_set_ipv6_connectivitytopubnub_coreapito switch preferred connectivity protocol.fix(proxy): add proxy context reset on connection close
Make sure that in case of connection close (including because of error) proxy context object will be reset.