Remove length limit from user id #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `user_id` length restriction for dynamically allocated memory for it. build(CMakeLists): add `try_compile` configuration Configure `try_compile` when building static library.
parfeon
added
status: done
parfeon
requested review from
Xavrax,
seba-aln and
KGronek-Pubnub
as code owners
CMakeLists.txt
Outdated
Comment on lines
63
to
71
| num_option(USE_RETRY_CONFIGURATION "Use requests retry" OFF) | ||
| num_option(USE_REDidONFIGURATION "Use requests retry" OFF) |
There was a problem hiding this comment.
Is this a typo? Below "USE_RETRY_CONFIGURATION" is still used.
There was a problem hiding this comment.
ooh, don't wake computer with keyboard when last opened was your IDE :D
Xavrax
approved these changes
Jan 9, 2025
|
@Xavrax Server code doesn't have any hard limits on |
|
@pubnub-release-bot release |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(user_id): remove length limit from user id
Remove the
user_idlength restriction for dynamically allocated memory for it.build(CMakeLists): add
try_compileconfigurationConfigure
try_compilewhen building a static library.