Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eventEngine #334

Merged
merged 67 commits into from
Jan 16, 2024
Merged

eventEngine #334

merged 67 commits into from
Jan 16, 2024

Conversation

mohitpubnub
Copy link
Contributor

@mohitpubnub mohitpubnub commented Aug 18, 2023 •
edited
Loading

feat: added enableEventEngine, maintainPresenceState flags and retryConfiguration for retry policy configuration.

Added enableEventEngine, maintainPresenceState flags and retryConfiguration for retry policy configuration.

fix: prevent duplicate listener registration.

Fixes issue of allowing duplicate listener registration.

fix: file name conflict in lib directory.

Fixes file name conflict in lib directory.

Closes #355

are and others added 20 commits November 15, 2022 14:59
@are
feat: cucumber refactor
ab2b9d9
@are
feat: add more steps
d1fad58
@are
Merge branch 'master' of github.com:pubnub/javascript into feat/cucum…
95b6674 
…ber-refactor
@are
feat: current progress
11a5670
@mohitpubnub
refactor event-engine(from draft PR)
eb35e90
@mohitpubnub
event-engine: update to latest description, added some missing transi…
f41d248 
…tions
@mohitpubnub
prettier!
6dd1294
@mohitpubnub
take: fix hanging tests due to retry intro
ab2b566
@mohitpubnub
update as per latest event engine specs
64d2371
@mohitpubnub
Merge branch 'master' into CLEN-1127
85af6b4
@mohitpubnub
* cucumber tsflow
8afa248
@mohitpubnub
prettier!
c030e31
@mohitpubnub
fix: test and version mismatch from branch merge
e01236c
@mohitpubnub
fix: version
4f77d20
@mohitpubnub
add: reconnection configuration
0ac5cc7
@mohitpubnub
Merge branch 'CLEN-1127' into CLEN_1361_event_engine_test
ecd43ca
@mohitpubnub
lint/prettier
1c376a9
@mohitpubnub
fix: test. destroy() not required
09d7708
@mohitpubnub
fix: naming convention and removed unnecessary effect dispatch
0a2e391
@mohitpubnub
WIP: presence event engine
701a44f
parfeon
parfeon requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vert few questions are left.

src/event-engine/core/retryPolicy.ts Outdated Show resolved Hide resolved
src/event-engine/dispatcher.ts Show resolved Hide resolved
src/event-engine/states/receiving.ts Outdated Show resolved Hide resolved
src/event-engine/states/receive_stopped.ts Outdated Show resolved Hide resolved
src/event-engine/states/receive_failed.ts Outdated Show resolved Hide resolved
src/event-engine/states/handshaking.ts Show resolved Hide resolved
src/event-engine/states/handshaking.ts Outdated Show resolved Hide resolved
src/event-engine/states/handshake_stopped.ts Outdated Show resolved Hide resolved
src/event-engine/states/handshake_reconnecting.ts Outdated Show resolved Hide resolved
src/event-engine/states/handshake_failed.ts Outdated Show resolved Hide resolved
@mohitpubnub mohitpubnub requested a review from parfeon January 15, 2024 02:58
parfeon
parfeon requested changes Jan 15, 2024
View reviewed changes
src/event-engine/core/retryPolicy.ts Outdated Show resolved Hide resolved
src/event-engine/core/retryPolicy.ts Outdated Show resolved Hide resolved
src/event-engine/states/receive_stopped.ts Outdated Show resolved Hide resolved
src/event-engine/states/handshake_stopped.ts Outdated Show resolved Hide resolved
src/event-engine/states/handshake_reconnecting.ts Outdated Show resolved Hide resolved
src/event-engine/states/handshake_failed.ts Outdated Show resolved Hide resolved
src/event-engine/states/handshake_failed.ts Outdated Show resolved Hide resolved
@mohitpubnub mohitpubnub requested a review from parfeon January 15, 2024 12:59
parfeon
parfeon requested changes Jan 15, 2024
View reviewed changes
src/event-engine/states/handshaking.ts Outdated Show resolved Hide resolved
src/event-engine/states/receive_failed.ts Outdated Show resolved Hide resolved
parfeon
parfeon approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohitpubnub
Copy link
Contributor Author

@pubnub-release-bot release as v7.5.0

@mohitpubnub
Copy link
Contributor Author

@pubnub-release-bot release as v7.5.0

@mohitpubnub mohitpubnub merged commit f0bd4e5 into master Jan 16, 2024
6 of 7 checks passed
@mohitpubnub mohitpubnub deleted the presence branch January 16, 2024 06:29
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techwritermat techwritermat techwritermat approved these changes

@parfeon parfeon parfeon approved these changes

@MikeDobrzan MikeDobrzan Awaiting requested review from MikeDobrzan

@seba-aln seba-aln Awaiting requested review from seba-aln seba-aln is a code owner

@kazydek kazydek Awaiting requested review from kazydek kazydek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mohitpubnub @pubnub-release-bot @parfeon @techwritermat @are