Fix presence leave call on used channels #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue with `Subscription` and `SubscriptionSet` when one can unsubscribe channel / group which is still in use by another. fix(network): fix fetch resource error report as bad request Fix particular `TypeError` emitted when browser forcefully close long-poll connection before its timeout and reported as bad request. This type of error will be reported as network error.
parfeon
added
status: done
mohitpubnub
approved these changes
Dec 12, 2024
| @@ -68,9 +69,18 @@ export abstract class SubscribeCapable { | |||
| * Stop real-time events processing. | |||
| */ | |||
| unsubscribe() { | |||
| this.pubnub.unregisterSubscribeCapable(this); | |||
| * | ||
| * @internal | ||
| */ | ||
| public unregisterSubscribeCapable(subscribeCapable: SubscribeCapable) { |
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(presence): fix presence leave call on used channels
Fix issue with
SubscriptionandSubscriptionSetwhen one can unsubscribe channel / group which is still in use by another.fix(network): fix fetch resource error report as bad request
Fix particular
TypeErroremitted when browser forcefully closes long-poll connection before its timeout and reported as bad request. This type of error will be reported as a network error.fix(node-fetch):
keepAlivefor Node.js 19+Fix issue because of which
node-fetchused default agent, which after Node.js 19+ haskeepAliveenabled by default.