Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up provider internals #1591

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

flostadler
Copy link
Contributor

@flostadler flostadler commented Jan 22, 2025

This change cleans up the provider internals in preparation for more involved features like adding EFA support (#1564). This was necessary because there was still a substantial amount of legacy cruft in the provider that wasn't even exposed to users (seem to be leftovers from moving the nodejs implementation onto MLCs).
Additionally it slightly reorganizes the internal module structure in order to have a more manageable code structure (compared to the current flat structure and HUGE files).

This change should be fully transparent to users.

In preparation for more involved features like adding EFA support, this
This change cleans up the provider internals in preparation for more involved
features like adding EFA support. This was necessary because there was still
a substantial amount of legacy cruft in the provider that wasn't even exposed
to users (seem to be leftovers from moving the nodejs implementation onto MLCs).
Additionally it slightly reorganizes the internal module structure in order
to have a more manageable code structure (compared to the current flat structure).

This change should be transparent to users.
@flostadler
Copy link
Contributor Author

flostadler commented Jan 22, 2025

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@flostadler flostadler self-assigned this Jan 22, 2025
@flostadler flostadler requested review from t0yv0, corymhall and a team January 22, 2025 15:29
@flostadler flostadler marked this pull request as ready for review January 22, 2025 15:29
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@flostadler flostadler merged commit 3328fbe into master Jan 24, 2025
34 checks passed
@flostadler flostadler deleted the flostadler/clean-provider-internals branch January 24, 2025 13:54
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants