Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of a syntax error in a service account code example #758

Closed
snamber opened this issue Mar 19, 2022 · 5 comments
Closed

Fix of a syntax error in a service account code example #758

snamber opened this issue Mar 19, 2022 · 5 comments
Labels
blocked The issue cannot be resolved without 3rd party action. kind/bug Some behavior is incorrect or out of spec resolution/duplicate This issue is a duplicate of another issue

Comments

@snamber
Copy link

snamber commented Mar 19, 2022

File: themes/default/content/registry/packages/gcp/api-docs/serviceAccount/account/_index.md

The imported module "serviceAccount" needs to be lowercase to work: "serviceaccount"

Now it is

package main

import (
	"github.com/pulumi/pulumi-gcp/sdk/v6/go/gcp/serviceAccount"
	"github.com/pulumi/pulumi/sdk/v3/go/pulumi"
)

func main() {
	pulumi.Run(func(ctx *pulumi.Context) error {
		_, err := serviceAccount.NewAccount(ctx, "serviceAccount", &serviceAccount.AccountArgs{
			AccountId:   pulumi.String("service-account-id"),
			DisplayName: pulumi.String("Service Account"),
		})
		if err != nil {
			return err
		}
		return nil
	})
}

It should be

package main

import (
	"github.com/pulumi/pulumi-gcp/sdk/v6/go/gcp/serviceaccount"
	"github.com/pulumi/pulumi/sdk/v3/go/pulumi"
)

func main() {
	pulumi.Run(func(ctx *pulumi.Context) error {
		_, err := serviceaccount.NewAccount(ctx, "serviceAccount", &serviceaccount.AccountArgs{
			AccountId:   pulumi.String("service-account-id"),
			DisplayName: pulumi.String("Service Account"),
		})
		if err != nil {
			return err
		}
		return nil
	})
}
@susanev
Copy link
Contributor

susanev commented Mar 19, 2022

thx for the report!

a few related issues

im going to close out the pulumi-hugo one as a dupe, since it doesn't make much sense for it to be in that repo anymore.

@susanev susanev added the kind/bug Some behavior is incorrect or out of spec label Mar 19, 2022
@susanev
Copy link
Contributor

susanev commented May 13, 2022

it was noted in community slack, that serviceAccount 404s, from the left nav of the gcp API docs; if you adjust the URL to serviceAccount it works

@jkodroff
Copy link
Member

@susanev Removing from your board because the root issue is we have the namespace incorrect in the provider. This is a breaking change, so we will need to wait until the next major release of pulumi-gcp to fix.

@susanev
Copy link
Contributor

susanev commented Jun 2, 2022

thank you!

@susanev susanev added the blocked The issue cannot be resolved without 3rd party action. label Jun 2, 2022
@jkodroff jkodroff removed their assignment Aug 15, 2022
@mnlumi mnlumi added the resolution/duplicate This issue is a duplicate of another issue label Oct 26, 2023
@mnlumi
Copy link
Contributor

mnlumi commented Oct 26, 2023

Duplicate of pulumi/pulumi-gcp#722

@mnlumi mnlumi closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked The issue cannot be resolved without 3rd party action. kind/bug Some behavior is incorrect or out of spec resolution/duplicate This issue is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants