You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wouldn't recommend for anyone to host this utility in its current state.
Current SQL handler classes do not filter database queries, allowing SQL injection vulnerabilities
An attacker can obtain full access to PvPGN database including all emails, usernames, and passwords (easy to crack XSHA1)
In addition to the SQL injection vulnerabilities, the mysql_* database functions have been removed from PHP7 in favor of MySQLi and PDO, so it won't run on new OS installs, for example Debian 9.
Both issues can be fixed by updating the code to use PDO. I began working on a patch but didn't finish it yet, hopefully someone else who is more familiar with PHP can upgrade the util.
SQL Injection Vulnerable Parameters:
POST /ladder/stats.php?action=search HTTP/1.1
game=W2BN&type=team&user_search=[INJECT]&x=1&y=10
GET /ladder/stats.php?game=[INJECT]&type=[INJECT]&sortBy=username&sort_direction=[INJECT] HTTP/1.1
GET /ladder/stats.php?game=W2BN&type=1&user=[INJECT] HTTP/1.1
The text was updated successfully, but these errors were encountered:
reillychase
changed the title
pvpgn-stats: Multiply SQL injection vulnerabilities, and mysql_* functions removed from PHP7
pvpgn-stats: Multiple SQL injection vulnerabilities, and mysql_* functions removed from PHP7
Sep 12, 2017
I wouldn't recommend for anyone to host this utility in its current state.
In addition to the SQL injection vulnerabilities, the mysql_* database functions have been removed from PHP7 in favor of MySQLi and PDO, so it won't run on new OS installs, for example Debian 9.
Both issues can be fixed by updating the code to use PDO. I began working on a patch but didn't finish it yet, hopefully someone else who is more familiar with PHP can upgrade the util.
SQL Injection Vulnerable Parameters:
game=W2BN&type=team&user_search=[INJECT]&x=1&y=10
GET /ladder/stats.php?game=[INJECT]&type=[INJECT]&sortBy=username&sort_direction=[INJECT] HTTP/1.1
GET /ladder/stats.php?game=W2BN&type=1&user=[INJECT] HTTP/1.1
The text was updated successfully, but these errors were encountered: