Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condense and simplify dependencies - Numpy-Groupies #4

Open
ssomnath opened this issue Sep 28, 2020 · 1 comment
Open

Condense and simplify dependencies - Numpy-Groupies #4

ssomnath opened this issue Sep 28, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ssomnath
Copy link
Member

Do we really NEED Numpy-groupies, Igor, gwfile, etc.? Check every dependency and remove from setup if unnecessary
@ssomnath ssomnath added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 28, 2020
@ssomnath
Copy link
Member Author

ssomnath commented Sep 29, 2020 •
edited
Loading

Turns out we could get rid of Igor and gwfile (used by Gwiddion). I have done this on the master branch.

We cannot yet get rid of numpy-groupies since it is apparently used to build a histogram for the BE ODF and NDF translators. I suggest using numpy instead to provide a simple mean or similar and dropping this niche dependency on numpy-groupies.

@ssomnath ssomnath changed the title Check and clean up dependencies in setup Condense and simplify dependencies - Numpy-Groupies Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ssomnath