-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show License-Expression if present in package metadata #13145
Conversation
Could you add a test for the new output? Thanks. |
Also, it looks like CI is failing as the |
cc804f4
to
09d36f0
Compare
I'm trying to, but have a hard time with simulating the data - do I have to create a package with new metadata in order to make pip "install" it and then assert the output? Any pointers will be appreciated. One more thing is, when pip itself moves to PEP 639 & setuptools supports it, this won't be true anymore: |
You might have to - there's some examples in |
FYI, CI should be working again, if you merge from main. |
09d36f0
to
246f323
Compare
With Core Metadata 2.4 a new field, License-Expression, has been added. If it's present, favor it over the deprecated (with PEP 639) legacy unstructured License field. Closes: pypa#13112
246f323
to
41c807c
Compare
Took me a while, but there are two tests added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the contribution! |
Thank you indeed. Congratulations on the PEP! 🎉 |
With Core Metadata 2.4 a new field, License-Expression, has been added. If it's present, favor it over the deprecated (with PEP 639) legacy unstructured License field.
Closes: #13112