Junitxml file flat, causes issues in GoCD?

[joshua-badger]

I believe I've run into this issue on GoCD: gocd/gocd#983

When I look at my output junitxml, it's on one line. However, when I look at example xml files in documentation and other sources, the output is multilined and seems as though it would parse correctly. Is there an option I'm missing somewhere that could "pretty print" the XML out and be in multiple lines (similar to the indent option in printing json)? If not, I'm certain I can come up with a solution, but I'd love to have it work out of the box.

We're running our tests in a docker container.
Pytest 5.4.3
Python 3.8.2

What other information can I provide?

[RonnyPfannschmidt]

[rpfannsc@ronny-t490-local scratch]$ virtualenv oldpytest
created virtual environment CPython3.8.5.final.0-64 in 130ms
  creator CPython3Posix(dest=/home/rpfannsc/Projects/scratch/oldpytest, clear=False, global=False)
  seeder FromAppData(download=False, pip=latest, setuptools=latest, wheel=latest, via=copy, app_data_dir=/home/rpfannsc/.local/share/virtualenv/seed-app-data/v1.0.1)
  activators BashActivator,CShellActivator,FishActivator,PowerShellActivator,PythonActivator,XonshActivator
[rpfannsc@ronny-t490-local scratch]$ . oldpytest/bin/activate
(oldpytest) [rpfannsc@ronny-t490-local scratch]$ pip install pytest==5.4.3
Collecting pytest==5.4.3
  Using cached pytest-5.4.3-py3-none-any.whl (248 kB)
Collecting pluggy<1.0,>=0.12
  Using cached pluggy-0.13.1-py2.py3-none-any.whl (18 kB)
Collecting attrs>=17.4.0
  Downloading attrs-20.3.0-py2.py3-none-any.whl (49 kB)
     |████████████████████████████████| 49 kB 1.8 MB/s 
Collecting packaging
  Using cached packaging-20.4-py2.py3-none-any.whl (37 kB)
Collecting more-itertools>=4.0.0
  Downloading more_itertools-8.6.0-py3-none-any.whl (45 kB)
     |████████████████████████████████| 45 kB 3.8 MB/s 
Collecting py>=1.5.0
  Using cached py-1.9.0-py2.py3-none-any.whl (99 kB)
Collecting wcwidth
  Using cached wcwidth-0.2.5-py2.py3-none-any.whl (30 kB)
Collecting six
  Using cached six-1.15.0-py2.py3-none-any.whl (10 kB)
Collecting pyparsing>=2.0.2
  Using cached pyparsing-2.4.7-py2.py3-none-any.whl (67 kB)
Installing collected packages: pluggy, attrs, six, pyparsing, packaging, more-itertools, py, wcwidth, pytest
Successfully installed attrs-20.3.0 more-itertools-8.6.0 packaging-20.4 pluggy-0.13.1 py-1.9.0 pyparsing-2.4.7 pytest-5.4.3 six-1.15.0 wcwidth-0.2.5
WARNING: You are using pip version 20.1; however, version 20.2.4 is available.
You should consider upgrading via the '/home/rpfannsc/Projects/scratch/oldpytest/bin/python -m pip install --upgrade pip' command.
(oldpytest) [rpfannsc@ronny-t490-local scratch]$ echo "def test_fail(): 1/0" > test_fail.py
(oldpytest) [rpfannsc@ronny-t490-local scratch]$ pytest test_fail.py --junitxml junit.xml
==================================================================================================================================================== test session starts =====================================================================================================================================================
platform linux -- Python 3.8.5, pytest-5.4.3, py-1.9.0, pluggy-0.13.1
rootdir: /home/rpfannsc/Projects/scratch
collected 1 item                                                                                                                                                                                                                                                                                                             

test_fail.py F                                                                                                                                                                                                                                                                                                         [100%]

========================================================================================================================================================== FAILURES ==========================================================================================================================================================
_________________________________________________________________________________________________________________________________________________________ test_fail __________________________________________________________________________________________________________________________________________________________

>   def test_fail(): 1/0
E   ZeroDivisionError: division by zero

test_fail.py:1: ZeroDivisionError
====================================================================================================================================================== warnings summary ======================================================================================================================================================
oldpytest/lib/python3.8/site-packages/_pytest/junitxml.py:417
  /home/rpfannsc/Projects/scratch/oldpytest/lib/python3.8/site-packages/_pytest/junitxml.py:417: PytestDeprecationWarning: The 'junit_family' default value will change to 'xunit2' in pytest 6.0.
  Add 'junit_family=xunit1' to your pytest.ini file to keep the current format in future versions of pytest and silence this warning.
    _issue_warning_captured(deprecated.JUNIT_XML_DEFAULT_FAMILY, config.hook, 2)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
------------------------------------------------------------------------------------------------------------------------------- generated xml file: /home/rpfannsc/Projects/scratch/junit.xml --------------------------------------------------------------------------------------------------------------------------------
================================================================================================================================================== short test summary info ===================================================================================================================================================
FAILED test_fail.py::test_fail - ZeroDivisionError: division by zero
================================================================================================================================================ 1 failed, 1 warning in 0.01s ================================================================================================================================================
(oldpytest) [rpfannsc@ronny-t490-local scratch]$ less junit.xml 
(oldpytest) [rpfannsc@ronny-t490-local scratch]$ cat junit.xml 
<?xml version="1.0" encoding="utf-8"?><testsuites><testsuite errors="0" failures="1" hostname="ronny-t490-local" name="pytest" skipped="0" tests="1" time="0.016" timestamp="2020-11-12T09:12:59.865668"><testcase classname="test_fail" file="test_fail.py" line="0" name="test_fail" time="0.000"><failure message="ZeroDivisionError: division by zero">&gt;   def test_fail(): 1/0
E   ZeroDivisionError: division by zero

test_fail.py:1: ZeroDivisionError</failure></testcase></testsuite></testsuites>(oldpytest) [rpfannsc@ronny-t490-local scratch]$ 

as far as i can tell this works as intended
the gocd handler is wrong

there is no pytest builtin option atm
you might want to consider a xml prettyprint postprocessing step to work around gocd being wrong

[joshua-badger]

We will consider a xml prettyprint postprocessing step, then. Thanks!