Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A grab bag of nits :) #17

Closed
shubho opened this issue Jun 2, 2020 · 1 comment
Closed

A grab bag of nits :) #17

shubho opened this issue Jun 2, 2020 · 1 comment

Comments

@shubho
Copy link

shubho commented Jun 2, 2020

  1. What is the argument to create_random_device_generator_with_token? Is it just any string? Maybe good to document that in README.md

  2. In Design section of README.md, " on CPU or CUDA to" -> "on CPU or on GPU using CUDA"

  3. In csprng.cu - my_random_kernel_cuda is not a good token

  4. Line 93 of aes.cuh - I don't know if the C/C++ standards says that unsigned always means unsigned int - maybe good to be explicit

  5. test_geometric has some commented out lines - this maybe tracked in another issue?

@pbelevich
Copy link
Contributor

  1. Fixed in Unify create_random_device_generator() and create_random_device_generator_with_token() #23
  2. Fixed in Minor fixes #26
  3. Fixed in Minor fixes #26
  4. Fixed in Minor fixes #26
  5. There is a TODO and a link to Improve test_geometric #7 in the commented out lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants