Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zrot for applying Givens rotation #28

Open
kevinsung opened this issue Sep 22, 2023 · 1 comment
Open

Use zrot for applying Givens rotation #28

kevinsung opened this issue Sep 22, 2023 · 1 comment
Assignees
Labels
needs upstream change Requires a change in an upstream library performance Performance improvement rust Involves writing Rust

Comments

@kevinsung
Copy link
Collaborator

One of these calls to zscal can be eliminated by either merging with the one in the next loop or by redefining the Givens rotation so that it only requires one phasing operation:

zscal(dim_b, phase_conj, row_i, 1);
zdrot(dim_b, row_i, 1, row_j, 1, c, s);
zscal(dim_b, phase, row_i, 1);

@kevinsung
Copy link
Collaborator Author

kevinsung commented Sep 22, 2023

Actually, it's better to use a single call to zrot once it's available: blas-lapack-rs/blas#43

@kevinsung kevinsung changed the title Eliminate one zscal call in Givens rotation Use zrot for Givens rotation Sep 22, 2023
@kevinsung kevinsung changed the title Use zrot for Givens rotation Use zrot for applying Givens rotation Sep 23, 2023
@kevinsung kevinsung added the needs upstream change Requires a change in an upstream library label Oct 26, 2023
@kevinsung kevinsung self-assigned this Nov 25, 2023
@kevinsung kevinsung added the rust Involves writing Rust label Jun 1, 2024
@kevinsung kevinsung added the performance Performance improvement label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs upstream change Requires a change in an upstream library performance Performance improvement rust Involves writing Rust
Projects
None yet
Development

No branches or pull requests

1 participant