Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage with sass v1.65 breaks due to usage of rem(...) #8

Open
jafin opened this issue Aug 14, 2023 · 0 comments
Open

Usage with sass v1.65 breaks due to usage of rem(...) #8

jafin opened this issue Aug 14, 2023 · 0 comments

Comments

@jafin
Copy link

jafin commented Aug 14, 2023

Running sass 1.65 changelog against the qg-main.scss web-template will result in errors with usage of function rem (expecting 2 parameters, got 1)

For Example:
https://github.com/qld-gov-au/web-template-release/blob/master/scss/scss-general/bootstrap/_variables.scss

$h1-font-size:                rem(25px) !default;
$h2-font-size:                rem(20px);
$h3-font-size:                rem(18px) !default;
$h4-font-size:                $font-size-base !default;
$h5-font-size:                rem(12px) !default;
$h6-font-size:                rem(11px) !default;

Repo Steps

Execute sass (dart-sass) against qg-main.scss
npx sass qg-main.scss
Note errors on output.

There is a function defined as rem in css/scss-general/bootstrap/_rem.scss, perhaps this is not overwriting the sass internal rem in the new version?

Workaround

revert to sass 1.64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant