Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-wrappers.d.ts wrong generic types #17743

Open
bwillert opened this issue Jan 9, 2025 · 1 comment
Open

app-wrappers.d.ts wrong generic types #17743

bwillert opened this issue Jan 9, 2025 · 1 comment
Labels
area/cli area/typescript bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. flavour/quasar-cli-webpack kind/bug 🐞 Qv2 🔝 Quasar v2 issues

Comments

@bwillert
Copy link

bwillert commented Jan 9, 2025

What happened?

After the update to app-webpack 4.0.5 I got errors in my boot files regarding the type of the params being of type any.

image

The problem is the types in app-wrappers.d.ts

The BootCallback is defined non-generic in boot.d.ts, but is being used as a generic Type in app-wrappers.d.ts

The same goes for PrefetchCallback and RouteCallback

Or am I missing something?

What did you expect to happen?

Types to be correct.

Reproduction URL

https://stackblitz.com/edit/quasarframework-stackblitz-templates-zpvg52k3?file=src%2Fboot%2Ftest.ts

How to reproduce?

Wait until loading finishes, then hover over params in src/boot/test.ts.
It shows the error Parameter 'params' implicitly has an 'any' type.

Flavour

Quasar CLI with Webpack (@quasar/cli | @quasar/app-webpack)

Areas

Quasar CLI Commands/Configuration (@quasar/cli | @quasar/app-webpack | @quasar/app-vite)

Platforms/Browsers

No response

Quasar info output

No response

Relevant log output

No response

Additional context

No response

@bwillert bwillert added kind/bug 🐞 Qv2 🔝 Quasar v2 issues labels Jan 9, 2025
@github-actions github-actions bot added area/cli bug/1-repro-available A reproduction is available and needs to be confirmed. flavour/quasar-cli-webpack labels Jan 9, 2025
@yusufkandemir yusufkandemir added bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. area/typescript and removed bug/1-repro-available A reproduction is available and needs to be confirmed. labels Jan 9, 2025
@yusufkandemir
Copy link
Member

It must be a leftover from dropping Vuex support. Works fine in app-vite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli area/typescript bug/2-confirmed We have reproduce the problem and confirmed that this is a bug. flavour/quasar-cli-webpack kind/bug 🐞 Qv2 🔝 Quasar v2 issues
Projects
None yet
Development

No branches or pull requests

2 participants