Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Sessions #521

Closed
shipa988 opened this issue Nov 21, 2022 · 2 comments
Closed

Dynamic Sessions #521

shipa988 opened this issue Nov 21, 2022 · 2 comments

Comments

@shipa988
Copy link

shipa988 commented Nov 21, 2022 •
edited
Loading

Sorry for repeating this issue! it's a real trouble for me!

Hi, It seems like after this PR change I can't logon using dynamic session:
#446

To me it seem that the code change is only initializing listen ports/listeners on static sessions specified in .cfg configuration file, could you please double check the PR and confirm if I am wrong?

Thanks!
@mikhailovavexmocom
Copy link

mikhailovavexmocom commented Nov 22, 2022 •
edited
Loading

this was originally posted at #466

fix approach: #522

@mikhailovavexmocom mikhailovavexmocom mentioned this issue Nov 22, 2022
Closed
@ackleymi
Copy link
Member

ackleymi commented Dec 7, 2022

Resolved in #527

@ackleymi ackleymi closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MUST have ports defined per session -> CAN have ports defined per se… mikhailovavexmocom/quickfix
3 participants
@ackleymi @shipa988 @mikhailovavexmocom