Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initiator got stuck during stopping procedure #666

Closed
filinvadim opened this issue Aug 27, 2024 · 2 comments
Closed

Initiator got stuck during stopping procedure #666

filinvadim opened this issue Aug 27, 2024 · 2 comments

Comments

@filinvadim
Copy link

filinvadim commented Aug 27, 2024

First of all please excuse me for a lack of information - this is all i have honestly.

I have stopping function wrapper:

func stopInitiator() {
	stopChan := make(chan struct{})
	go func() {
		f.cli.Stop()
		close(stopChan)
	}()
	select {
	case <-stopChan:
	case <-time.After(time.Minute):
		panic("fix initiator stopping timeout")
	}
}

Expected behavior: successful initiator stopping.
Given behavior: initiator.Stop() method got stuck eternally -> panic.

@ackleymi
Copy link
Member

ackleymi commented Sep 6, 2024

Hi, I found a bug with initiator stops hanging, I fixed it here - #669. Please let me know if you have further thoughts.

@ackleymi ackleymi closed this as completed Sep 6, 2024
@filinvadim
Copy link
Author

I believe it's still stuck during reconnect tryouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants