-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chapter 4 edits #312
base: main
Are you sure you want to change the base?
chapter 4 edits #312
Conversation
We should time order Figure 4.3, especially since the text refers to the timing |
In the collider discussion, this isn't clear to me
I haven't seen this, though I'm sure you're right that it happens. What I'm more familiar with is the box around the collider, which is read out as an open path. Do we want to mention that as well? |
In the callout box, we have
which removes arrows from the DAG. It's not exactly what ggdag_adjustment_set does, since that function grays out the adjusted edges (which is typically preferred). Suggest changing those line colors instead. |
In our next meeting, it would be great to talk about choice of adjustment method in the context of m-bias. I believe there are cases where IPW can be robust against this (certainly true that it can resolve selection bias) while direct/regression adjustment cannot. I think this has to do with the notion that weighting "removes arrows" while regression adjustment and/or stratification "draws boxes." |
The job is failing because we need the dev version of tidysmd now, but I'll take care of that before merging
Maybe I'm not sure what you mean, but we already use and discuss the box notation. What did you have in mind?
I want it like this so people are forced to think about the structure and the arrows. In the workshop, though, we later show the time-ordered version, which we don't here. We should add that to the time-ordering section
Yes, it is.
I've thought this through already, and it can, but it's silly. You could use g-comp or IPW the same way you do for time-varying exposures/confounding, but it would require you to have the two unmeasured confounders, in which case you could just adjust for them through direct adjustment. So you can, but it's not that helpful. |
labels = scales::label_percent() | ||
) + | ||
theme( | ||
axis.title = element_blank() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is your thinking here that it's clear from the axis what this is? It doesn't seem that way to me the way it can be obvious from other labels.
@@ -485,7 +486,7 @@ In the code above, we assume that: | |||
- a graduate student's mood, sense of humor, and how prepared they feel for the exam could influence whether they listened to a podcast the morning of the test | |||
- their mood and how prepared they are also influence their exam score | |||
|
|||
Notice we *do not* see podcast in the exam equation; this means that we assume that there is *no* causal relationship between podcast and the exam score. | |||
Notice we *do not* see podcast in the exam equation; this means that we are constructing this DAG under the null assumption that there is *no* causal relationship between listening to the podcast and the exam score. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice we *do not* see podcast in the exam equation; this means that we are constructing this DAG under the null assumption that there is *no* causal relationship between listening to the podcast and the exam score. | |
Notice we *do not* see podcast in the exam equation; this means that we assume that there is *no* causal relationship between podcast and the exam score. | |
This is sometimes called a **null DAG**. |
What if we separate these ideas and make it a little more explicit? We bring up null DAGs later, so it might be useful to emphasize
Note to self: I was wrong about |
Mostly minor edits